Skip to content

YARN-11050. Typo in method name: RMWebServiceProtocol#removeFromCluserNodeLabels#3805

Merged
zhuqi-lucas merged 1 commit intoapache:trunkfrom
szilard-nemeth:YARN-11050
Dec 18, 2021
Merged

YARN-11050. Typo in method name: RMWebServiceProtocol#removeFromCluserNodeLabels#3805
zhuqi-lucas merged 1 commit intoapache:trunkfrom
szilard-nemeth:YARN-11050

Conversation

@szilard-nemeth
Copy link
Contributor

@szilard-nemeth szilard-nemeth commented Dec 15, 2021

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

hadoop-yetus commented Dec 16, 2021

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 123m 19s Maven dependency ordering for branch
+1 💚 mvninstall 24m 32s trunk passed
+1 💚 compile 3m 54s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 3m 11s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 10s trunk passed
+1 💚 mvnsite 1m 25s trunk passed
+1 💚 javadoc 1m 11s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 4s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 2m 34s trunk passed
+1 💚 shadedclient 22m 48s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 1m 15s the patch passed
+1 💚 compile 3m 49s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 3m 49s the patch passed
+1 💚 compile 3m 8s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 3m 8s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 3s the patch passed
+1 💚 mvnsite 1m 14s the patch passed
+1 💚 javadoc 0m 59s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 56s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 2m 51s the patch passed
+1 💚 shadedclient 22m 55s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 100m 7s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 2m 27s hadoop-yarn-server-router in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
329m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3805/1/artifact/out/Dockerfile
GITHUB PR #3805
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 5eae66605a35 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 467e58e
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3805/1/testReport/
Max. process+thread count 923 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3805/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

brumi1024
brumi1024 approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@brumi1024 brumi1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szilard-nemeth for the patch. LGTM.

@zhuqi-lucas
Copy link
Contributor

zhuqi-lucas commented Dec 18, 2021

Thanks @szilard-nemeth for this patch, LGTM.
Merged to trunk.

@zhuqi-lucas zhuqi-lucas merged commit 0714142 into apache:trunk Dec 18, 2021
@szilard-nemeth
Copy link
Contributor Author

szilard-nemeth commented Dec 20, 2021 •
edited
Loading

Hi @zhuqi-lucas ,
Thanks for the review and commit.
I can see the commit message only contains: "YARN-11050 (#3805)".
By convention, I can see all the committers are adding the jira title or the PR title to the commit message, in this format:

YARN-<number>. <jira title or commit message>. <contributed by x>

Is this intentional? I don't think it's worth a revert, though.

@zhuqi-lucas
Copy link
Contributor

zhuqi-lucas commented Dec 20, 2021

Thanks @szilard-nemeth for reminder.
Actually we should use the format, but i also think it don't need revert, it's just a typo fix.

@szilard-nemeth
Copy link
Contributor Author

szilard-nemeth commented Dec 20, 2021 •
edited
Loading

Thanks @szilard-nemeth for reminder. Actually we should use the format, but i also think it don't need revert, it's just a typo fix.

@zhuqi-lucas
Agreed. I only considered the revert because of the commit message but I don't think it's worth the hassle.

hotcodemacha pushed a commit to hotcodemacha/hadoop that referenced this pull request Dec 22, 2021
@szilard-nemeth @hotcodemacha
YARN-11050 (apache#3805)
8c306b5
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@szilard-nemeth
YARN-11050 (apache#3805)
67b5613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brumi1024 brumi1024 brumi1024 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szilard-nemeth @hadoop-yetus @zhuqi-lucas @brumi1024